Re: [PATCH] GNOME VFS support for dia

[Lars Clausen <lrclause cs uiuc edu>]

On 23 Nov 2003, W. Michael Petullo wrote:
> I wrote a quick patch for dia (CVS tree as of Nov 23) that adds support
> for opening and manipulating GNOME VFS URIs.  I did this using
> libgnomevfs, libgsf and the gsf_xml_parser_context function.  The new
> code is enabled as long as the GNOME preprocessor variable is #define'd
> (--enable-gnome).
>
> So now "dia file:///path/to/diagram.dia" should work, with the following
> caveats:
>
> 1.  For some reason compression is not working (it only works with
> uncompressed files).  If anyone has experience with gsf_input_gzip_new,
> I could use your help!
>
> 2.  I have not yet looked at the import and export filters, but I suspect
> they may need modification too.
>
> Comments?

Two so far:  Shouldn't Gnome fall back on normal file opening if VFS fails?
And the bit about creating a tmp file is the way it is for Win32
compatibility. 

The import and export filters ought to be redone to call just one file
opening function, then.  We don't want to have this complexity in 15
different places.

-Lars

-- 
Lars Clausen (http://shasta.cs.uiuc.edu/~lrclause)| HĂ„rdgrim of Numenor
"I do not agree with a word that you say, but I   |----------------------------
will defend to the death your right to say it."   | Where are we going, and
    --Evelyn Beatrice Hall paraphrasing Voltaire  | what's with the handbasket?