Re: uml class operations italicised

[Lars Clausen <lrclause cs uiuc edu>]

On Fri, 17 Jan 2003, Paul Roberts wrote:
> Hi Lars, thanks for you reply.
> 
> On Fri, Jan 17, 2003 at 10:58:53AM -0600, Lars Clausen wrote:
> 
>> You haven't set the Normal font in the Class tab of the UML properties
>> to Italic, have you?
> 
> I just checked, and no, its set to Courier.

Ah, I see it.  It's a bit of code that didn't get updated when the virtual
bit was added.  It's fixed in CVS, and here's a 0.90 patch that will do the
same:

Index: objects/UML/class.c
===================================================================
RCS file: /cvs/gnome/dia/objects/UML/class.c,v
retrieving revision 1.42
diff -u -r1.42 class.c
--- objects/UML/class.c 29 Apr 2002 22:31:33 -0000      1.42
+++ objects/UML/class.c 17 Jan 2003 18:17:54 -0000
@@ -342,7 +342,7 @@
       while (list != NULL) {
        UMLOperation *op = (UMLOperation *)list->data;
        /* Must add a new font for virtual yet not abstract methods. Bold Italic for abstract? */
-       if (op->inheritance_type != UML_LEAF) {
+       if (op->inheritance_type == UML_ABSTRACT) {
          font = umlclass->abstract_font;
           font_height = umlclass->abstract_font_height;
           p.y += umlclass->abstract_font_ascent;

-Lars

-- 
Lars Clausen (http://shasta.cs.uiuc.edu/~lrclause)| Hårdgrim of Numenor
"I do not agree with a word that you say, but I   |----------------------------
will defend to the death your right to say it."   | Where are we going, and
    --Evelyn Beatrice Hall paraphrasing Voltaire  | what's with the handbasket?